Refactored Windows-specific code#539
Merged
hugtalbot merged 1 commit intosofa-framework:masterfrom Oct 17, 2025
Merged
Conversation
… == 'win32'` to improve readability and robustness. Added helper functions to reduce duplication and handle missing SOFAPYTHON3_ROOT safely. Maintained existing behavior while preventing potential crashes and improving compatibility.
hugtalbot
approved these changes
Oct 16, 2025
RafaelPalomar
pushed a commit
to Slicer/SofaPython3
that referenced
this pull request
Jan 28, 2026
… == 'win32'` to improve readability and robustness. Added helper functions to reduce duplication and handle missing SOFAPYTHON3_ROOT safely. Maintained existing behavior while preventing potential crashes and improving compatibility. (sofa-framework#539)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored Windows-specific code under
if sofa_root and sys.platform == 'win32'to improve readability and robustness. Added helper functions to reduce duplication and handle missing SOFAPYTHON3_ROOT safely. Maintained existing behavior while preventing potential crashes and improving compatibility.